Remove an outdated test #16361
Merged
Remove an outdated test #16361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR scala#16257 introduced a test for bindings in type annotations. Simultanously, scala#16150 disallowed the syntax that allowed the test to parse and compile. The test should be no longer needed.
|
My bad, should have rebuilt. Thank you. |
dwijnand
approved these changes
Nov 17, 2022
|
Need to fix some other test cases. |
nicolasstucki
approved these changes
Nov 18, 2022
|
I will merge this PR without passing all tests because it brings us one step closer to fix #16367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix CI.
PR #16257 introduced a test for handling bindings in type annotations inside match cases. Simultaneously, #16150 disallowed the same syntax.
Because of that the test should no longer be necessary, as it only pertains to the removed feature.