Fix errors in explicit type annotations in inline match cases #16257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Unapply trees would have type bindings generated inside their body and this was the only case handled in InlineReducer. However, this mainly happened for inferred type parameters, and Unapply with an explicit binding inside a type annotation was not handled, leading to a "cannot reduce match" error. This case is now handled and a related comment was added as well.
Fixes #15971
For context, a more concise minimization then the one proposed in the issue above would be something like:
And the issue itself ended up being unrelated to macros. I tried submitting this PR with the original minimization, however checker (-Ycheck) returned an exception, failing the tests. I tried to debug that as well, however I honestly spent an excessive amount of time on that, so for now I would like to at the very least, submit this fix for now, and reattempt fixing the checker later. For that reason I created a separate issue for the check failures, with a new minimization, in #16331.