Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfreeze scalacheck #931

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions configs/community.dbuild
Original file line number Diff line number Diff line change
Expand Up @@ -185,17 +185,10 @@ build += {
]
}

// forked (October 2018) for JDK 11 friendliness
// frozen (February 2019) at a December 2018 commit
// because of a downstream circe failure, reported here:
// https://github.com/circe/circe/issues/1084
${vars.base} {
name: "scalacheck"
uri: ${vars.uris.scalacheck-uri}
extra.projects: ["jvm"] // no Scala.js please
extra.commands: ${vars.base.extra.commands} [
"set jvm/Test/unmanagedSources/excludeFilter := HiddenFileFilter || \"SerializabilitySpecification.scala\""
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't any evidence that this test is disabled. Appears to run, and run successfully.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the way we filter out some tests stopped working in sbt 1.3.0-RCx. I'm going to dig into it later, but anyway, good to know that we don't need to filter the test anymore.

}

// see also scalatest-tests
Expand Down
2 changes: 1 addition & 1 deletion configs/project-refs.conf
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ vars.uris: {
scala-xml-quote-uri: "https://github.com/allanrenucci/scala-xml-quote.git#bintray"
scala-xml-uri: "https://github.com/scala/scala-xml.git#1.x"
scalacheck-shapeless-uri: "https://github.com/alexarchambault/scalacheck-shapeless.git#294ff5ce33dddc82" # was master
scalacheck-uri: "https://github.com/scalacommunitybuild/scalacheck.git#community-build-2.13" # was rickynils, master; was ricknyils, 1.14.0_sonatype
scalacheck-uri: "https://github.com/rickynils/scalacheck.git"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the community-build branch with current master, and there are few if any changes, now.

scalachess-uri: "https://github.com/ornicar/scalachess.git"
scaladex-uri: "https://github.com/scalacenter/scaladex.git#8f943f1961" # was master
scalafix-uri: "https://github.com/scalacenter/scalafix.git#387fd2725ce" # was master
Expand Down