Unfreeze scalacheck #931
Unfreeze scalacheck #931
Conversation
ashawley
commented
Jun 28, 2019
•
ashawley
commented
- JDK 11 fix was merged in use valueOf for construction class Character typelevel/scalacheck#433
- Circe seems to be building ok
| @@ -139,7 +139,7 @@ vars.uris: { | |||
| scala-xml-quote-uri: "https://github.com/allanrenucci/scala-xml-quote.git#bintray" | |||
| scala-xml-uri: "https://github.com/scala/scala-xml.git#1.x" | |||
| scalacheck-shapeless-uri: "https://github.com/alexarchambault/scalacheck-shapeless.git#294ff5ce33dddc82" # was master | |||
| scalacheck-uri: "https://github.com/scalacommunitybuild/scalacheck.git#community-build-2.13" # was rickynils, master; was ricknyils, 1.14.0_sonatype | |||
| scalacheck-uri: "https://github.com/rickynils/scalacheck.git" | |||
There was a problem hiding this comment.
I compared the community-build branch with current master, and there are few if any changes, now.
| ${vars.base} { | ||
| name: "scalacheck" | ||
| uri: ${vars.uris.scalacheck-uri} | ||
| extra.projects: ["jvm"] // no Scala.js please | ||
| extra.commands: ${vars.base.extra.commands} [ | ||
| "set jvm/Test/unmanagedSources/excludeFilter := HiddenFileFilter || \"SerializabilitySpecification.scala\"" | ||
| ] |
There was a problem hiding this comment.
There isn't any evidence that this test is disabled. Appears to run, and run successfully.
There was a problem hiding this comment.
I think the way we filter out some tests stopped working in sbt 1.3.0-RCx. I'm going to dig into it later, but anyway, good to know that we don't need to filter the test anymore.
|
Oh, was this originally an issue only with 2.12? Should I check that first? |
|
(hey, I've been on vacation, and now I'm behind on community build stuff. I will definitely get to this) |
|
I cherry-picked this onto 2.12.x as aefa2e6 and also merged it onto 2.13.x. if any problems ensue, we'll deal with them then :-) thanks for bringing this up. |
|
@ashawley I'm seeing SOEs in circe and kittens at e.g. https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/4665/ , do you make anything of the errors? I think I might need to just revert this |
|
I didn't experience that for 2.13. Is it only for 2.12? |
|
it's the same on 2.13, see https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-community-build/2334/ |
|
Well, Travis Brown was able to merge a fix quickly in circe/circe#1199. Looks like a 2.13 build kicked off https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-community-build/2336/ |
