Improve experience when using a GitHub App #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormation for auth
|
A snapshot release has been created as You can test it out with: uses: scala-steward-org/scala-steward-action@snapshots/428It will be automatically recreated on any change to this PR. |
exoego
approved these changes
Dec 16, 2022
|
A snapshot release has been created as You can test it out with: uses: scala-steward-org/scala-steward-action@snapshots/428It will be automatically recreated on any change to this PR. |
rtyley
added a commit
to guardian/scala-steward-public-repos
that referenced
this pull request
Jun 2, 2023
Working on #44 - now that scala-steward-org/scala-steward-action#428 updated the Scala Steward GitHub Action to have its _own_ support for GitHub App authentication, we can remove the additional 'Generate token' step from our GitHub Action workflow, with these benefits: * No longer need to use the tibdex/github-app-token - one fewer action we need to trust * In a subsequent step, we may be able to remove the necessity of adding repos to `REPOSITORIES.md` - as, so far as I can see, the GitHub Action will now automatically run on all repos we install it on, without having to also add them to `REPOSITORIES.md`: https://github.com/scala-steward-org/scala-steward/blob/113884ac11d639ed8b70fc368f6a69895b14f8ba/modules/core/src/main/scala/org/scalasteward/core/application/StewardAlg.scala#L97-L98
rtyley
added a commit
to guardian/scala-steward-public-repos
that referenced
this pull request
Jun 2, 2023
Working on #44 - now that scala-steward-org/scala-steward-action#428 updated the Scala Steward GitHub Action to have its _own_ support for GitHub App authentication, we can remove the additional 'Generate token' step from our GitHub Action workflow, with these benefits: * No longer need to use the tibdex/github-app-token - one fewer action we need to trust! * Running the Scala Steward action on a repo no longer requires adding the repo to REPOSITORIES.md - only granting the installation access to the repo is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 How to review this PR?
This PR was created with the idea of being reviewed commit by commit. Each commit contains an incremental change that makes it easier to review. Also some of the commits contain additional information in their description to help understand why the change was made.
I also recommend checking "Hide whitespace" when reviewing this PR!
🚀 What does include this PR?
This PR adds two new inputs related to GitHub Apps:
github-app-installation-id: The ID of the installation where we want to run Scala Steward.github-app-auth-only: If set totruethegithub-app-*inputs will only be used for authentication purposes, not for getting the list of repositories to update.As part of this change, if a user provides the
github-app-installation-idinput, the GitHub App Token will be directly retrieved by this action, making theGenerate tokenstep on this guide obsolete.🧑💻 Subsequent work
A full documentation revamp will be performed in a subsequent PR.