-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate token step is now obsolete, Scala Steward natively supports the GitHub App #44
Comments
rtyley
added a commit
that referenced
this issue
Jun 2, 2023
Working on #44 - now that scala-steward-org/scala-steward-action#428 updated the Scala Steward GitHub Action to have its _own_ support for GitHub App authentication, we can remove the additional 'Generate token' step from our GitHub Action workflow, with these benefits: * No longer need to use the tibdex/github-app-token - one fewer action we need to trust * In a subsequent step, we may be able to remove the necessity of adding repos to `REPOSITORIES.md` - as, so far as I can see, the GitHub Action will now automatically run on all repos we install it on, without having to also add them to `REPOSITORIES.md`: https://github.com/scala-steward-org/scala-steward/blob/113884ac11d639ed8b70fc368f6a69895b14f8ba/modules/core/src/main/scala/org/scalasteward/core/application/StewardAlg.scala#L97-L98
rtyley
added a commit
that referenced
this issue
Jun 2, 2023
Working on #44 - now that scala-steward-org/scala-steward-action#428 updated the Scala Steward GitHub Action to have its _own_ support for GitHub App authentication, we can remove the additional 'Generate token' step from our GitHub Action workflow, with these benefits: * No longer need to use the tibdex/github-app-token - one fewer action we need to trust! * Running the Scala Steward action on a repo no longer requires adding the repo to REPOSITORIES.md - only granting the installation access to the repo is required.
Fixed by #46 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See scala-steward-org/scala-steward-action#428 - if I read this right, we can not only remove the
Generate token
:scala-steward-public-repos/.github/workflows/reusable-scala-steward.yml
Lines 25 to 30 in 4cb4a8e
...but we may also be able to remove the use of
REPOSITORIES.md
- just giving the GitHub App access to the repo will be enough.The text was updated successfully, but these errors were encountered: