Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ganache-cli related code from API & tests #849

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Feb 4, 2024

  • Remove ganache-cli dev dep

  • Remove detect-port dep

  • Remove ganache client related code

  • Remove ganache related docs

  • Update API docs with attachToHardhat example

  • Throw error when --network flag is used

TO DO

  • Look into coverage drop (probably ratio issue)

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6739db6) 95.85% compared to head (fcfb966) 95.91%.

Files Patch % Lines
plugins/resources/nomiclabs.utils.js 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #849      +/-   ##
==========================================
+ Coverage   95.85%   95.91%   +0.06%     
==========================================
  Files          19       19              
  Lines        1061      980      -81     
==========================================
- Hits         1017      940      -77     
+ Misses         44       40       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgewecke cgewecke merged commit c6eea4b into master Feb 5, 2024
3 checks passed
@cgewecke cgewecke deleted the remove-ganache-support branch February 5, 2024 01:28
@cgewecke cgewecke mentioned this pull request Feb 5, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants