Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-alert): add close fade-out animation #2943

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

TomMenga
Copy link
Contributor

@TomMenga TomMenga commented Jul 17, 2024

Preflight Checklist

Issue

This PR Closes #2745

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • Add fade-out animation for sbb-alert
  • sbb-alert [animation] default value changed from open => all

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Important change: animation property default value changes from open to all (the close animation is enabled by default)

Other information

BEGIN_COMMIT_OVERRIDE
feat(sbb-alert): add close fade-out animation and change animation property default to all (#2943)
END_COMMIT_OVERRIDE

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 17, 2024
@TomMenga TomMenga self-assigned this Jul 17, 2024
@TomMenga TomMenga added the pr: lead review required A lead review is required for this pull request label Jul 17, 2024
@TomMenga TomMenga changed the title docs(sbb-alert): add close fade-out animation feat(sbb-alert): add close fade-out animation Jul 17, 2024
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/elements/alert/alert/alert.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added pr: lead review approved Pull request has been approved by a lead review and removed pr: lead review required A lead review is required for this pull request labels Jul 22, 2024
@TomMenga TomMenga merged commit 581b95c into main Jul 22, 2024
15 of 16 checks passed
@TomMenga TomMenga deleted the feat/alert-close-animation branch July 22, 2024 13:35
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jul 22, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: visual review required preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

story: alert should have same fade out animation on close as notification
3 participants