Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

story: alert should have same fade out animation on close as notification #2745

Closed
jeripeierSBB opened this issue Jun 12, 2024 · 1 comment · Fixed by #2943
Closed

story: alert should have same fade out animation on close as notification #2745

jeripeierSBB opened this issue Jun 12, 2024 · 1 comment · Fixed by #2943
Assignees

Comments

@jeripeierSBB
Copy link
Contributor

No description provided.

@jeripeierSBB jeripeierSBB converted this from a draft issue Jun 12, 2024
@jeripeierSBB jeripeierSBB changed the title alert should have same fade out animation on close as notification story: alert should have same fade out animation on close as notification Jun 12, 2024
@TomMenga TomMenga self-assigned this Jul 15, 2024
@TomMenga TomMenga moved this from Next to In progress in ESTA Web Lyne Design System Jul 15, 2024
@TomMenga
Copy link
Contributor

TomMenga commented Jul 15, 2024

I have a couple of questions/topics to discuss:

  1. In the current implementation, the alert has no close API. When clicking the closing button, it just emits a requestDismissal. Proposal:
  • remove the requestDismissal event
  • Add a cancellable willClose and a didOpen event
  • Expose a close method that will be called automatically when clicking the closing button (as the sbb-notification)
  1. The animation property type default change from open to all (as the sbb-notification)

These changes would both generate a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants