Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sbb-datepicker): add support for DateAdapter #2889

Merged
merged 4 commits into from
Jul 5, 2024
Merged

feat(sbb-datepicker): add support for DateAdapter #2889

merged 4 commits into from
Jul 5, 2024

Conversation

kyubisation
Copy link
Contributor

@kyubisation kyubisation commented Jul 4, 2024 •
edited
Loading

This change adds support for the DateAdapter to all datepicker related components (<sbb-datepicker>, <sbb-datepicker-toggle>, <sbb-datepicker-previous-day> and <sbb-datepicker-next-day>).

Closes #2865, closes #1915

Partially supersedes #2244 (Thank you @DavideMininni-Fincons for the initial work!)

@kyubisation kyubisation requested a review from jeripeierSBB as a code owner July 4, 2024 10:54
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 4, 2024
@kyubisation
feat(sbb-datepicker): add support for DateAdapter
fd9ef9f 
This change adds support for the `DateAdapter` to all datepicker
related components (`<sbb-datepicker>`, `<sbb-datepicker-toggle>`,
`<sbb-datepicker-previous-day>` and `<sbb-datepicker-next-day>`).

Closes #2865
@kyubisation kyubisation force-pushed the feat-date-adapter-support branch from 9c54f9a to fd9ef9f Compare July 4, 2024 11:29
@github-actions github-actions bot temporarily deployed to pr2889 July 4, 2024 11:47 Inactive
jeripeierSBB
jeripeierSBB approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as discussed

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jul 4, 2024
MarioCastigliano
MarioCastigliano reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@MarioCastigliano MarioCastigliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the refactoring and I don't see anything wrong, but I'll play with it a bit to make sure all edge cases are still working as expected. 👍

src/elements/datepicker/datepicker/datepicker.ts Outdated Show resolved Hide resolved
MarioCastigliano
MarioCastigliano approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@MarioCastigliano MarioCastigliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Jul 5, 2024
@kyubisation kyubisation merged commit 4d9973e into main Jul 5, 2024
20 checks passed
@kyubisation kyubisation deleted the feat-date-adapter-support branch July 5, 2024 10:30
@github-actions github-actions bot mentioned this pull request Jul 5, 2024
Merged
This was referenced Nov 4, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioCastigliano MarioCastigliano MarioCastigliano approved these changes

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
3 participants
@kyubisation @jeripeierSBB @MarioCastigliano