-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(sbb-datepicker): dateParser gets called too many times #1915
Comments
The reason for this is that all satellite components (sbb-datepicker-next-day, sbb-datepicker-previous-day...) listen to the change event to check if any state needs to be updated (e.g. disable arrows). To solve this problem there are two possible approaches:
Given the low priority and the imperceptible impact on performance, we decided to wait for @kyubisation to discuss this and choose a solution that is in line with the project's common practices. |
I'm tempted to postpone this until our framework migration, with which valueAsDate can be directly used. |
If you select a date in calendar, the dateParser function gets called 4 times. We can improve it to call it fewer times.
The text was updated successfully, but these errors were encountered: