-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix. Unused_import rule should ignore all standard operator funs #880
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
74998dd
bugfix/unused-import-operator(#837)
aktsay6 8613fca
bugfix/unused-import-operator(#837)
aktsay6 5d035d9
Merge branch 'master' into bugfix/unused-import-operator(#837)
aktsay6 dfc5b20
bugfix/unused-import-operator(#837)
aktsay6 cdd0ab2
Merge branch 'master' into bugfix/unused-import-operator(#837)
petertrr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ import org.cqfn.diktat.util.LintTestBase | |
|
||
import com.pinterest.ktlint.core.LintError | ||
import generated.WarningNames | ||
import org.junit.jupiter.api.Disabled | ||
import org.junit.jupiter.api.Tag | ||
import org.junit.jupiter.api.Test | ||
|
||
|
@@ -394,4 +395,83 @@ class FileStructureRuleTest : LintTestBase(::FileStructureRule) { | |
""".trimMargin(), | ||
) | ||
} | ||
|
||
@Test | ||
@Tag(WarningNames.UNUSED_IMPORT) | ||
fun `check by #1`() { | ||
lintMethod( | ||
""" | ||
|package org.cqfn.diktat.example | ||
| | ||
|import com.example.get | ||
|import com.example.invoke | ||
|import com.example.set | ||
|import kotlin.properties.Delegates | ||
| | ||
|fun main() { | ||
| val a by Delegates.observable() | ||
|} | ||
""".trimMargin(), | ||
) | ||
} | ||
|
||
@Test | ||
@Tag(WarningNames.UNUSED_IMPORT) | ||
fun `check by #2 should not trigger`() { | ||
lintMethod( | ||
""" | ||
|package org.cqfn.diktat.example | ||
| | ||
|import com.example.get | ||
|import com.example.invoke | ||
|import com.example.set | ||
|import tasks.getValue | ||
| | ||
|fun main() { | ||
| val a by tasks.getting | ||
|} | ||
""".trimMargin(), | ||
) | ||
} | ||
|
||
@Test | ||
@Tag(WarningNames.UNUSED_IMPORT) | ||
fun `check by #3 should trigger`() { | ||
lintMethod( | ||
""" | ||
|package org.cqfn.diktat.example | ||
| | ||
|import Delegate | ||
|import com.example.get | ||
|import com.example.invoke | ||
|import com.example.set | ||
| | ||
|fun main() { | ||
| val a | ||
|} | ||
""".trimMargin(), | ||
LintError(1, 1, ruleId, "${Warnings.UNUSED_IMPORT.warnText()} Delegate - unused import", true) | ||
) | ||
} | ||
|
||
@Disabled | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please provide a reason |
||
@Test | ||
@Tag(WarningNames.UNUSED_IMPORT) | ||
fun `check by #4 should trigger`() { | ||
lintMethod( | ||
""" | ||
|package org.cqfn.diktat.example | ||
| | ||
|import com.example.get | ||
|import com.example.invoke | ||
|import com.example.set | ||
|import tasks.getValue | ||
| | ||
|fun main() { | ||
| val a | ||
|} | ||
""".trimMargin(), | ||
LintError(1, 1, ruleId, "${Warnings.UNUSED_IMPORT.warnText()} tasks.getValue - unused import", true) | ||
) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you disable deleting imports from operatorMap?