Bugfix. Unused_import rule should ignore all standard operator funs #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Fixed bug * Added test
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
============================================
- Coverage 83.53% 83.51% -0.03%
Complexity 2215 2215
============================================
Files 101 101
Lines 5690 5689 -1
Branches 1628 1628
============================================
- Hits 4753 4751 -2
Misses 256 256
- Partials 681 682 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cheshiriks
reviewed
May 12, 2021
Comment on lines
78
to
82
| // Fixme: this imports should be deleted if unused | ||
| private val ignoreOperators = setOf("getValue", "plus", "minus", "times", "div", | ||
| "rem", "rangeTo", "contains", "plusAssign", "minusAssign", "timesAssign", | ||
| "divAssign", "remAssign", "compareTo", "inc", "dec", "unaryPlus", "unaryMinus", "not") | ||
|
|
There was a problem hiding this comment.
Can we supplement the dictionary with operatorMap operators in AstConstants.kt so that these operators are not ignored?
### What's done: * Fixed bug
petertrr
approved these changes
May 12, 2021
| ) | ||
| } | ||
|
|
||
| @Disabled |
Cheshiriks
reviewed
May 12, 2021
| importName | ||
| ) | ||
| ) { | ||
| } else if (importName != null && !ignoreImports.contains(importName) && !refSet.contains(importName) && !operatorMap.containsKey(importName)) { |
There was a problem hiding this comment.
Why did you disable deleting imports from operatorMap?
Cheshiriks
approved these changes
May 12, 2021
### What's done: * Fixed bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #837