Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for domain name #696

Merged
merged 11 commits into from
Jan 19, 2021
Merged

Warning for domain name #696

merged 11 commits into from
Jan 19, 2021

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Jan 12, 2021

Actions checklist

### What's done:
Created new warning, tests and documentations
@kentr0w kentr0w added the enhancement New feature or request label Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #696 (ac2db15) into master (0b61701) will decrease coverage by 0.00%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #696      +/-   ##
============================================
- Coverage     80.11%   80.10%   -0.01%     
- Complexity     1893     1894       +1     
============================================
  Files            90       90              
  Lines          4909     4912       +3     
  Branches       1573     1575       +2     
============================================
+ Hits           3933     3935       +2     
- Misses          238      239       +1     
  Partials        738      738              
Flag Coverage Δ Complexity Δ
unittests 80.10% <63.63%> (-0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...fn/diktat/common/config/rules/RulesConfigReader.kt 31.03% <0.00%> (ø) 4.00 <0.00> (ø)
...fn/diktat/ruleset/rules/files/FileStructureRule.kt 81.30% <57.14%> (+0.30%) 63.00 <0.00> (+1.00)
...lin/org/cqfn/diktat/ruleset/rules/PackageNaming.kt 91.76% <76.92%> (-1.10%) 35.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b61701...ac2db15. Read the comment docs.

### What's done:
   Fixed according our code-style
### What's done:
   Fixed according our code-style
### What's done:
   Fixed after review
### What's done:
   Fixed according our code-style
### What's done:
   Fixed after review
### What's done:
   Fixed according our code-style
### What's done:
   Fixed after review
### What's done:
   Fixed according our code-style
### What's done:
   Fixed according our code-style
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kentr0w kentr0w merged commit b43fb71 into master Jan 19, 2021
@kentr0w kentr0w deleted the feature/no-domain-name branch January 19, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle case when domainName is empty in config
2 participants