Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case when domainName is empty in config #678

Closed
petertrr opened this issue Dec 29, 2020 · 0 comments · Fixed by #696
Closed

Handle case when domainName is empty in config #678

petertrr opened this issue Dec 29, 2020 · 0 comments · Fixed by #696
Assignees

Comments

@petertrr
Copy link
Member

What should we do? Throw an error? Do nothing? Log warning?

Also, atomic counter in PackageNaming should be commented: it's there so that warning is logged only once per project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants