Add unit tests for mis-indented expression body functions #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1363 +/- ##
============================================
+ Coverage 83.59% 83.68% +0.08%
- Complexity 2567 2588 +21
============================================
Files 106 106
Lines 7291 7386 +95
Branches 2018 2048 +30
============================================
+ Hits 6095 6181 +86
Misses 353 353
- Partials 843 852 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
approved these changes
Jun 15, 2022
...st-framework/src/main/kotlin/org/cqfn/diktat/test/framework/processing/TestComparatorUnit.kt
Show resolved
Hide resolved
nulls
reviewed
Jun 15, 2022
| */ | ||
| private fun readFile(fileName: String): List<String> { | ||
| var list: List<String> = ArrayList() | ||
| private fun readFile(file: Path): List<String> = |
There was a problem hiding this comment.
maybe move to companion as in another class?
There was a problem hiding this comment.
Thanks for the heads-up. Addressed with 80a9e3f.
0x6675636b796f75676974687562
force-pushed
the
feature/andrey.shcheglov/indentation-unit-tests
branch
from
0a16f9c to
80a9e3f
Compare
### What's done: * Added unit tests for mis-indented expression body functions. * See #1330.
…o the user ### What's done: * `columnWidth` increased from 80 to `Int.MAX_VALUE`, so deltas will no longer have any inline `<br/>`
### What's done: * `readFile()` moved to a companion object
0x6675636b796f75676974687562
force-pushed
the
feature/andrey.shcheglov/indentation-unit-tests
branch
from
80a9e3f to
e3aef73
Compare
0x6675636b796f75676974687562
deleted the
feature/andrey.shcheglov/indentation-unit-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
WRONG_INDENTATIONinspection #1330.