Supported comments after latest enum element #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * skip EOL_COMMENT, BLOCK_COMMENT, WHITE_SPACE to detect a location for COMMA
### What's done: * moved import
Codecov Report
@@ Coverage Diff @@
## master #1302 +/- ##
=========================================
Coverage 82.07% 82.08%
- Complexity 2534 2538 +4
=========================================
Files 105 105
Lines 7214 7223 +9
Branches 2061 2065 +4
=========================================
+ Hits 5921 5929 +8
Misses 346 346
- Partials 947 948 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
reviewed
May 26, 2022
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/EnumsSeparated.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/resources/test/paragraph3/enum_separated/LastElementCommentTest.kt
Outdated
Show resolved
Hide resolved
petertrr
approved these changes
May 27, 2022
### What's done: * supported KDoc in method for adding new line after each enum element
…6' into bugfix/enum_comma_at_comment#1286
### What's done: * removed dead code
…6' into bugfix/enum_comma_at_comment#1286
### What's done: * amend new line on tree level
…6' into bugfix/enum_comma_at_comment#1286
### What's done: * restored logic for newline with whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #1286