Skip to content

Commit

Permalink
Supported comments after latest enum element (#1302)
Browse files Browse the repository at this point in the history
### What's done:
* skip EOL_COMMENT, BLOCK_COMMENT, WHITE_SPACE to detect a location for COMMA
* supported KDoc in method for adding new line after each enum element
  • Loading branch information
nulls authored May 27, 2022
1 parent f7c9c8a commit 44507fd
Show file tree
Hide file tree
Showing 5 changed files with 204 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@ import org.cqfn.diktat.ruleset.utils.getAllChildrenWithType
import org.cqfn.diktat.ruleset.utils.hasChildOfType
import org.cqfn.diktat.ruleset.utils.isClassEnum

import com.pinterest.ktlint.core.ast.ElementType.BLOCK_COMMENT
import com.pinterest.ktlint.core.ast.ElementType.CLASS
import com.pinterest.ktlint.core.ast.ElementType.CLASS_BODY
import com.pinterest.ktlint.core.ast.ElementType.COMMA
import com.pinterest.ktlint.core.ast.ElementType.ENUM_ENTRY
import com.pinterest.ktlint.core.ast.ElementType.EOL_COMMENT
import com.pinterest.ktlint.core.ast.ElementType.IDENTIFIER
import com.pinterest.ktlint.core.ast.ElementType.LBRACE
import com.pinterest.ktlint.core.ast.ElementType.RBRACE
Expand Down Expand Up @@ -48,13 +50,22 @@ class EnumsSeparated(configRules: List<RulesConfig>) : DiktatRule(
if (!it.treeNext.isWhiteSpaceWithNewline()) {
ENUMS_SEPARATED.warnAndFix(configRules, emitWarn, isFixMode, "enum entries must end with a line break",
it.startOffset, it) {
it.appendNewlineMergingWhiteSpace(it.treeNext, it.treeNext)
it.appendNewline()
}
}
}
checkLastEnum(enumEntries.last())
}

private fun ASTNode.appendNewline() {
val nextNode = this.treeNext
if (nextNode.elementType == WHITE_SPACE) {
(nextNode as LeafPsiElement).rawReplaceWithText("\n${nextNode.text}")
} else {
this.treeParent.addChild(PsiWhiteSpaceImpl("\n"), nextNode)
}
}

private fun isEnumOneLine(nodes: List<ASTNode>) =
nodes.dropLast(1).none { it.treeNext.isWhiteSpaceWithNewline() }

Expand Down Expand Up @@ -87,10 +98,19 @@ class EnumsSeparated(configRules: List<RulesConfig>) : DiktatRule(
if (!node.hasChildOfType(COMMA)) {
ENUMS_SEPARATED.warnAndFix(configRules, emitWarn, isFixMode, "last enum entry must end with a comma",
node.startOffset, node) {
node.addChild(LeafPsiElement(COMMA, ","), node.findChildByType(SEMICOLON)!!.treePrev)
val commaLocation = node.findChildByType(SEMICOLON)!!.findLatestTreePrevMatching {
it.elementType !in setOf(EOL_COMMENT, BLOCK_COMMENT, WHITE_SPACE)
}
node.addChild(LeafPsiElement(COMMA, ","), commaLocation.treeNext)
}
}
}

private fun ASTNode.findLatestTreePrevMatching(predicate: (ASTNode) -> Boolean): ASTNode {
val result = this.treePrev
return if (predicate(result)) result else result.findLatestTreePrevMatching(predicate)
}

companion object {
const val NAME_ID = "abq-enum-separated"
private val simpleValue = listOf(IDENTIFIER, WHITE_SPACE, COMMA, SEMICOLON)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,10 @@ class EnumsSeparatedFixTest : FixTestBase("test/paragraph3/enum_separated", ::En
fun `test enums split`() {
fixAndCompare("EnumSeparatedExpected.kt", "EnumSeparatedTest.kt")
}

@Test
@Tag(WarningNames.ENUMS_SEPARATED)
fun `last element with comment`() {
fixAndCompare("LastElementCommentExpected.kt", "LastElementCommentTest.kt")
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ enum class ENUM {
enum class ENUM {
RED(0xFF0000),
GREEN(0x00FF00),
BLUE(0x0000FF) /*sdcsc*/,
BLUE(0x0000FF), /*sdcsc*/
;
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
package test.paragraph3.enum_separated

enum class Foo0 {
A,
B,
C,
;
}

enum class Foo11 {
A,
B,
C, // some comment 11
;
}

enum class Foo12 {
A,
B,
C,// some comment 12
;
}

enum class Foo13 {
A,
B,
C,
;// some comment 13
}

enum class Foo14 {
A,
B,
C,
; // some comment 14
}

enum class Foo21 {
A,
B,
C, /* some comment 21 */
;
}

enum class Foo22 {
A,
B,
C,/* some comment 22 */
;
}

enum class Foo23 {
A,
B,
C,
;/* some comment 23 */
}

enum class Foo24 {
A,
B,
C,
; /* some comment 24 */
}

enum class Foo31 {
A,
B,
C,
;
/** some comment 31 */
}

enum class Foo32 {
A,
B,
C,
;
/** some comment 32 */
}

enum class Foo33 {
A,
B,
C,
;
/** some comment 33 */
}

enum class Foo34 {
A,
B,
C,
;
/** some comment 34 */
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
package test.paragraph3.enum_separated

enum class Foo0 {
A,
B,
C
}

enum class Foo11 {
A,
B,
C // some comment 11
}

enum class Foo12 {
A,
B,
C// some comment 12
}

enum class Foo13 {
A,
B,
C;// some comment 13
}

enum class Foo14 {
A,
B,
C; // some comment 14
}

enum class Foo21 {
A,
B,
C /* some comment 21 */
}

enum class Foo22 {
A,
B,
C/* some comment 22 */
}

enum class Foo23 {
A,
B,
C;/* some comment 23 */
}

enum class Foo24 {
A,
B,
C; /* some comment 24 */
}

enum class Foo31 {
A,
B,
C /** some comment 31 */
}

enum class Foo32 {
A,
B,
C/** some comment 32 */
}

enum class Foo33 {
A,
B,
C;/** some comment 33 */
}

enum class Foo34 {
A,
B,
C; /** some comment 34 */
}

0 comments on commit 44507fd

Please sign in to comment.