Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (a11y): add aria hidden to navigation flyout when visually hidden #811

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

virus-rpi
Copy link
Collaborator

@virus-rpi virus-rpi commented Sep 9, 2024

Changes:

  • add aria-hidden={!props.visible} to FullscreenOverlay

@virus-rpi virus-rpi requested a review from a team as a code owner September 9, 2024 14:45
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit 072f011
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/66eae09c9534300007cbfb4b
😎 Deploy Preview https://deploy-preview-811--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@virus-rpi virus-rpi changed the title fix (a11y): add aria hidden to NavigationFlyout when visually hidden fix (a11y): add aria hidden to navigation flyout when visually hidden Sep 9, 2024
Copy link
Member

@hofmann-felix hofmann-felix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change with a big impact 💪 Finally, the menu is not read out every time before the actual content

@hofmann-felix hofmann-felix mentioned this pull request Sep 13, 2024
20 tasks
@virus-rpi virus-rpi merged commit 5fcee62 into main Sep 18, 2024
6 checks passed
@virus-rpi virus-rpi deleted the chore/a11y/navigation/navigation-flyout branch September 18, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants