Skip to content

Commit

Permalink
fix (a11y): add aria hidden to navigation flyout when visually hidden (
Browse files Browse the repository at this point in the history
…#811)

* fix (a11y): add aria hidden to NavigationFlyout when visually hidden

* fix (a11y): remove unnecessary aria-hidden from background overlay

---------

Co-authored-by: noa.santo <[email protected]>
  • Loading branch information
virus-rpi and noa.santo authored Sep 18, 2024
1 parent 1e0ab8c commit 5fcee62
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/components/layout/header/menu-flyout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ interface NavigationFlyoutProp {
export const NavigationFlyout: React.FC<NavigationFlyoutProp> = (props) => {
return (
<>
<FullscreenOverlay $visible={props.visible} onClick={props.onClick}>
<FullscreenOverlay
$visible={props.visible}
onClick={props.onClick}
aria-hidden={!props.visible}
>
<ScrollContainer>
<FullHeightNavigation
translation={props.translation}
Expand Down

0 comments on commit 5fcee62

Please sign in to comment.