Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (a11y): add nav landmark to social and legal links #806

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix (a11y): add nav landmark to social and legal links #806

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
077b3f7
fix (a11y): add nav tag to "Data Protection" & "Imprint" in menu
Sep 2, 2024
fb66168
fix (a11y): add aria-label to landmarks
Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions src/components/layout/navigation/navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,21 +237,25 @@ const Navigation: React.FC<NavigationProps> = ({
</SocialLinks>
<LegalLinks>
<li>
<LegalLink
to="/imprint"
$isSelected={activePath.includes('/imprint')}
>
{t('navigation.imprint')}
</LegalLink>
<nav>
<LegalLink
to="/imprint"
$isSelected={activePath.includes('/imprint')}
>
{t('navigation.imprint')}
</LegalLink>
</nav>
</li>
<li aria-hidden={true}>·</li>
<li>
<LegalLink
to="/data-privacy"
$isSelected={activePath.includes('/data-privacy')}
>
{t('navigation.data-privacy')}
</LegalLink>
<nav>
<LegalLink
to="/data-privacy"
$isSelected={activePath.includes('/data-privacy')}
>
{t('navigation.data-privacy')}
</LegalLink>
</nav>
</li>
</LegalLinks>
<SiteNavigation>
Expand Down