Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (a11y): add nav landmark to social and legal links #806

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

virus-rpi
Copy link
Collaborator

@virus-rpi virus-rpi commented Sep 2, 2024

Changes:

  • add nav landmark to the legal links in the menu
  • add nav landmark to the social links in the menu

@virus-rpi virus-rpi requested a review from a team as a code owner September 2, 2024 15:02
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit fb66168
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/66df0307ebc0500008a5e002
😎 Deploy Preview https://deploy-preview-806--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@virus-rpi virus-rpi mentioned this pull request Sep 2, 2024
20 tasks
Copy link
Member

@georgiee georgiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this up! The idea is correct but I think there is an issue with the depth of the placement.

The nav tag is far too low by wrapping individual links. It should at least wrap the LegalInks. Maybe even higher to catch the social links.

Please gather some knowledge about navigation landmarks so you can decide properly. Also ensure each nav element has a unique aria-label or aria-labelledby attribute as we have more than one nav then.

Some starters I found:

fix (a11y): wrap whole legal links in nav landmark instead of wrapping the links individually
fix (a11y): wrap social links in nav landmark
@virus-rpi virus-rpi changed the title fix (a11y): add nav tag to "Data Protection" & "Imprint" in menu fix (a11y): add nav landmark to social and legal links Sep 9, 2024
@virus-rpi virus-rpi requested a review from georgiee September 10, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants