Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better screen reader text #790

Merged
merged 9 commits into from
Jan 29, 2024
Merged

feat: better screen reader text #790

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bf40197
feat: better screen reader text
Dec 19, 2023
d3a6df8
fix: netlify build error fix
Jan 15, 2024
b215f2f
Merge branch 'main' into chore/a11y-custumer-logo
georgiee Jan 16, 2024
25a07ce
Merge branch 'main' into chore/a11y-custumer-logo
georgiee Jan 16, 2024
060800b
fix: moved aria-customer-logo inside customer logo container
Jan 22, 2024
c290950
chore: add comment to AriaCustomerLogo component
Jan 22, 2024
cccad9a
Merge remote-tracking branch 'origin/chore/a11y-custumer-logo' into c…
Jan 22, 2024
7398abb
chore: ran prettier so test pass
Jan 22, 2024
a2fe8dc
fix: format fix
Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 56 additions & 16 deletions src/components/pages/landingpage/customers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,23 +66,63 @@ const CustomerLogo = ({
);
};

const AriaCustomerLogo = () => {
virus-rpi marked this conversation as resolved.
Show resolved Hide resolved
return (
<ul
style={{
position: 'absolute',
width: '1px',
height: '1px',
padding: '0',
margin: '-1px',
overflow: 'hidden',
clip: 'rect(0, 0, 0, 0)',
whiteSpace: 'nowrap',
border: '0',
listStyleType: 'none',
}}
aria-label={'Our Customers:'}
>
<li>Allianz</li>
<li>Rosenbauer</li>
<li>Media Markt</li>
<li>Saturn</li>
<li>Green City</li>
<li>FC Bayern</li>
<li>Zeiss</li>
<li>A.D.A.C</li>
virus-rpi marked this conversation as resolved.
Show resolved Hide resolved
</ul>
);
};

export const Customers = () => {
return (
<LogosContainer>
<LogoLine>
<CustomerLogo desktopWidth={330} mobileWidth={127} show="allianz" />
<CustomerLogo desktopWidth={451} mobileWidth={176} show="rosenbauer" />
</LogoLine>
<LogoLine>
<CustomerLogo desktopWidth={403} mobileWidth={170} show="mediamarkt" />
<CustomerLogo desktopWidth={285} mobileWidth={121} show="saturn" />
<CustomerLogo desktopWidth={337} mobileWidth={156} show="greencity" />
</LogoLine>
<LogoLine>
<CustomerLogo desktopWidth={112} mobileWidth={48} show="fcbayern" />
<CustomerLogo desktopWidth={92} mobileWidth={39} show="zeiss" />
<CustomerLogo desktopWidth={324} mobileWidth={138} show="adac" />
</LogoLine>
</LogosContainer>
<>
<LogosContainer aria-hidden={true}>
virus-rpi marked this conversation as resolved.
Show resolved Hide resolved
<LogoLine>
<CustomerLogo desktopWidth={330} mobileWidth={127} show="allianz" />
<CustomerLogo
desktopWidth={451}
mobileWidth={176}
show="rosenbauer"
/>
</LogoLine>
<LogoLine>
<CustomerLogo
desktopWidth={403}
mobileWidth={170}
show="mediamarkt"
/>
<CustomerLogo desktopWidth={285} mobileWidth={121} show="saturn" />
<CustomerLogo desktopWidth={337} mobileWidth={156} show="greencity" />
</LogoLine>
<LogoLine>
<CustomerLogo desktopWidth={112} mobileWidth={48} show="fcbayern" />
<CustomerLogo desktopWidth={92} mobileWidth={39} show="zeiss" />
<CustomerLogo desktopWidth={324} mobileWidth={138} show="adac" />
</LogoLine>
</LogosContainer>
<AriaCustomerLogo />
virus-rpi marked this conversation as resolved.
Show resolved Hide resolved
</>
);
};
2 changes: 1 addition & 1 deletion src/templates/blog-post.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const Head = ({
data.contentfulBlogPost;

const shareImagePath = heroImage.shareImage?.resize.src;

/*
* SEO Notes:
* Recommended meta description length these days is 120 - 158 characters. The lower number is relevant for mobile devices.
Expand Down
Loading