-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better screen reader text #790
Conversation
✅ Deploy Preview for satellytes ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The error:
But because i didn't modify anything in the file that causes the error I don't think this was caused by my changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An ideal solution would use the actual customer logos, have it in a list structure and then use css to spread them into the visual grid layout.
Your solution is much simpler but creates kind of a duplicated content: one part for the visuals and one part for the screen reads. I think that's good enough for now and better than the previous state anyway.
I approve this PR already but there are two comments you could deliver: a comment and something about the DOM
…hore/a11y-custumer-logo
the failing test is:
but I ran prettier before pushing |
Please run |
Changes:
Added a better way for screen readers to interpret the customer logos on the landing page
Screen reader text before:
Screen reader text after:
How to verify:
On Mac:
On Windows: