Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add managed nodepools as an option #73

Closed
alessiotoma opened this issue Jun 23, 2021 · 4 comments
Closed

Add managed nodepools as an option #73

alessiotoma opened this issue Jun 23, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@alessiotoma
Copy link

EKS nodepools can be now be tainted in the latest version of the Terraform AWS module ( see terraform-aws-modules/terraform-aws-eks#1403 ). On that basis, is there anything that is preventing us from moving from self-managed nodepools to managed nodepools ? This would make the EKS update process easier.

@thpang
Copy link
Member

thpang commented Jun 23, 2021

We've started looking into this one. As we find out information we'll provide feedback. There will also be a PR with the code changes addressing this issue.

@thpang thpang added the enhancement New feature or request label Jun 23, 2021
@thpang thpang changed the title Switch to managed nodepools Add managed nodepools as an option Jun 25, 2021
@egoienola
Copy link

Has this been implemented now? It certainly looks as though the commit call d66d5b9 introduced key changes necessary to switch to the managed node groups (commit message seems to confirm this). The following output also suggests that to be the case:
module.eks.module.eks_managed_node_group["cas"].aws_eks_node_group.this[0]: Still creating... [3m30s elapsed] module.eks.module.eks_managed_node_group["stateless"].aws_eks_node_group.this[0]: Still creating... [3m30s elapsed] module.eks.module.eks_managed_node_group["compute"].aws_eks_node_group.this[0]: Still creating... [3m30s elapsed] module.eks.module.eks_managed_node_group["default"].aws_eks_node_group.this[0]: Still creating... [3m30s elapsed]
Is there anything else pending to complete this request?

@dhoucgitter dhoucgitter self-assigned this Dec 7, 2023
@dhoucgitter
Copy link
Member

@egoienola, support for EKS managed node groups was added under PR #122 and was made available starting with release https://github.com/sassoftware/viya4-iac-aws/releases/tag/5.0.0

@dhoucgitter
Copy link
Member

Closing #73 as Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants