Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_eks_node_group supports taints from aws provider version 3.43.0 #1403

Closed
stevie- opened this issue May 28, 2021 · 2 comments · Fixed by #1424
Closed

aws_eks_node_group supports taints from aws provider version 3.43.0 #1403

stevie- opened this issue May 28, 2021 · 2 comments · Fixed by #1424

Comments

@stevie-
Copy link
Contributor

stevie- commented May 28, 2021

Is your request related to a new offering from AWS?

yes, scheduled for release 3.43.0
hashicorp/terraform-provider-aws#19310

Is your request related to a problem? Please describe.

Will solve workaround with kubelet_extra_args to add taints to nodes
and relates to some issues:
#1232
#1214
#1085
#962

Describe the solution you'd like.

Simply set the block and make it available as input variable similar to k8s_labels

resource "aws_eks_node_group" "example" {
  ...

  taint {
    key    = "dedicated"
    value  = "gpuGroup"
    effect = "NO_SCHEDULE"
  }

  taint {
    key    = "special"
    value  = "true"
    effect = "PREFER_NO_SCHEDULE"
  }
}

Describe alternatives you've considered.

Additional context

@stevie-
Copy link
Contributor Author

stevie- commented Jun 2, 2021

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants