Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for @-moz-document #372

Closed
ruslang02 opened this issue Jun 21, 2018 · 3 comments
Closed

Better support for @-moz-document #372

ruslang02 opened this issue Jun 21, 2018 · 3 comments

Comments

@ruslang02
Copy link

ruslang02 commented Jun 21, 2018

Actually repeating the same issue: sass/libsass#1401
When trying to compile https://github.com/material-components/material-components-web I am getting error:

Error: expected ")".
@-moz-document url-prefix("") {
                          ^
node_modules/@material/select/mdc-select.scss 64:31                     root stylesheet
node_modules/material-components-web/material-components-web.scss 38:9  
@import front/styles.scss 1:9  root stylesheet

Any ideas?

I use Node.js 8.9.3 accompanied with Electron v2.0.1 and [email protected] from NPM

File (that causes disaster) https://github.com/material-components/material-components-web/blob/master/packages/mdc-select/mdc-select.scss

@xzyfer
Copy link

xzyfer commented Jun 21, 2018

FWIW this feature is being removed in the next firefox release (61).
https://twitter.com/FxSiteCompat/status/1003967138057424897

@ruslang02
Copy link
Author

It would be really nice if I could manage it somehow, but I need to save originality of the NPM package, even though I absolutely don't need that hack (Electron = Chromium)

@nex3
Copy link
Contributor

nex3 commented Jun 22, 2018

@xzyfer Note that this specific case will still be supported for some time:

An exception is the empty url-prefix function that has been used as a CSS hack targeting Firefox. It continues to be parsed on the Release channel to avoid breakages but will be removed in the near future once major compatibility issues are solved.

nex3 added a commit that referenced this issue Jun 23, 2018
@nex3 nex3 closed this as completed in #379 Jun 27, 2018
nex3 added a commit that referenced this issue Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants