Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for @-moz-document #1401

Closed
xzyfer opened this issue Jul 27, 2015 · 5 comments
Closed

Better support for @-moz-document #1401

xzyfer opened this issue Jul 27, 2015 · 5 comments

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Jul 27, 2015

There are cases where we error when handling @-moz-document for example

@-moz-document url-prefix(http://sass-lang.com/docs) {
  .foo { a: b; }
}

Produces the following error

Error: expected a variable name (e.g. $x) or ')' for the parameter list for url-prefix
        on line 1 of test.scss
>> @-moz-document url-prefix(http://sass-lang.com/docs) {
   --------------------------^

Spec sass/sass-spec#460
Spec https://github.com/sass/sass-spec/tree/master/spec/libsass-todo-tests/scss-tests/127_test_moz_document_interpolation

@xzyfer
Copy link
Contributor Author

xzyfer commented Aug 24, 2015

Handling of url-prefix has been fixed in #1466. There remaining aspect of @-moz-document support are outstanding.

@mgreter
Copy link
Contributor

mgreter commented Sep 3, 2015

As I see it the only difference left is that we do not preserve line-feeds and spaces inside the list. Quite possible that there are other lists where we should preserve white-space!? Maybe want to close this and open a new one?

@mgreter
Copy link
Contributor

mgreter commented Jan 17, 2016

This might be fixed by #1868 (partially, the issue in this ticket is ok)

@mgreter
Copy link
Contributor

mgreter commented Jan 17, 2016

Closing in favor of #1596

@mgreter mgreter closed this as completed Jan 17, 2016
@mgreter mgreter self-assigned this Jan 17, 2016
@mgreter mgreter modified the milestones: 3.3.3, 3.4 Jan 17, 2016
@Designer023
Copy link

Designer023 commented Sep 26, 2016

Just a note for anyone who needs a workaround before the updated version is released (or is stuck on an old version) can try the following:

#{ '@-moz-document \url-prefix()' } {  ...  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants