Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract config loading #414

Merged
merged 3 commits into from
Feb 19, 2022
Merged

Extract config loading #414

merged 3 commits into from
Feb 19, 2022

Conversation

groenroos
Copy link
Member

Extract loading config, models, hooks, permissions, and controller into separate digest() methods, which only load and return the parsed, formatted, and validated object.

This helps the GUI use it independently, and ensure both load the same config the same way.

Closes #325

@groenroos groenroos added the enhancement Improvements to existing features and functionality label Feb 19, 2022
@groenroos groenroos added this to the M2 - Release 2.0 milestone Feb 19, 2022
@groenroos groenroos self-assigned this Feb 19, 2022
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #414 (922c1e2) into master (1600646) will increase coverage by 0.02%.
The diff coverage is 99.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   98.24%   98.27%   +0.02%     
==========================================
  Files          37       37              
  Lines        4450     4516      +66     
==========================================
+ Hits         4372     4438      +66     
  Misses         78       78              
Impacted Files Coverage Δ
core/loadHooks.js 98.83% <96.77%> (+0.26%) ⬆️
core/loadConfig.js 100.00% <100.00%> (ø)
core/loadController.js 100.00% <100.00%> (ø)
core/loadModel.js 100.00% <100.00%> (ø)
core/loadPermissions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1600646...922c1e2. Read the comment docs.

@groenroos groenroos merged commit d43e896 into master Feb 19, 2022
@groenroos groenroos deleted the feature/extracted-loading branch February 19, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features and functionality
Development

Successfully merging this pull request may close these issues.

Extract config loading into independent methods
1 participant