Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract config loading into independent methods #325

Closed
groenroos opened this issue Oct 27, 2021 · 1 comment · Fixed by #414
Closed

Extract config loading into independent methods #325

groenroos opened this issue Oct 27, 2021 · 1 comment · Fixed by #414
Assignees
Labels
feature Brand new features to Sapling refactoring Drastic code quality improvements

Comments

@groenroos
Copy link
Member

groenroos commented Oct 27, 2021

Currently, when Sapling digests config.json, permissions.json, hooks.json, methods and routing, they're all tightly coupled with initialising them for use.

However, this makes it hard for the GUI to extract the digested configuration for display.

Extract these from the core methods into separate, independently importable and runnable methods.

@groenroos groenroos added refactoring Drastic code quality improvements feature Brand new features to Sapling labels Oct 27, 2021
@groenroos groenroos added this to the M2 - Release 2.0 milestone Oct 27, 2021
@groenroos groenroos self-assigned this Oct 27, 2021
@groenroos
Copy link
Member Author

Unclear whether it would be cleaner to extract them as separate files that the core methods (and GUI) can import, or whether the core files should export the current default and a config digestion method from the same file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new features to Sapling refactoring Drastic code quality improvements
Development

Successfully merging a pull request may close this issue.

1 participant