Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Storage, Request and User #320

Merged
merged 6 commits into from
Oct 24, 2021
Merged

Tests for Storage, Request and User #320

merged 6 commits into from
Oct 24, 2021

Conversation

groenroos
Copy link
Member

As Storage was split out in #269, this PR brings tests for the methods in the various libs.

Testing for the remaining Storage methods isn't 100% coverage, as some parts of Storage are outdated/nonfunctional.

As a side effect, the Storage constructor was also standardised as per #268.

Closes #130, closes #268.

@groenroos groenroos added the maintenance Keep dependencies, code and conventions fresh label Oct 24, 2021
@groenroos groenroos self-assigned this Oct 24, 2021
@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #320 (6d88dfc) into master (8f52bd7) will increase coverage by 1.53%.
The diff coverage is 98.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   96.67%   98.21%   +1.53%     
==========================================
  Files          36       36              
  Lines        4367     4415      +48     
==========================================
+ Hits         4222     4336     +114     
+ Misses        145       79      -66     
Impacted Files Coverage Δ
lib/Storage.js 91.00% <97.72%> (+7.43%) ⬆️
core/loadModel.js 100.00% <100.00%> (ø)
hooks/sapling/model/retrieve.js 100.00% <100.00%> (ø)
hooks/sapling/user/login.js 100.00% <100.00%> (ø)
lib/Request.js 98.92% <100.00%> (+11.65%) ⬆️
lib/User.js 100.00% <100.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f52bd7...6d88dfc. Read the comment docs.

@groenroos groenroos merged commit c49d115 into master Oct 24, 2021
@groenroos groenroos deleted the test/storage branch October 24, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Keep dependencies, code and conventions fresh
Development

Successfully merging this pull request may close these issues.

Unify Storage init variables Write tests for Storage
1 participant