Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Storage #269

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Split Storage #269

merged 2 commits into from
Aug 4, 2021

Conversation

groenroos
Copy link
Member

Splits the Storage class between Storage, User, and a new Request class.

As a side bonus, adds a new test:nocov script to run tests without coverage, owing to c8 being so slow.

Closes #261

@groenroos groenroos added the refactoring Drastic code quality improvements label Aug 4, 2021
@groenroos groenroos added this to the M2 - Release 2.0 milestone Aug 4, 2021
@groenroos groenroos self-assigned this Aug 4, 2021
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #269 (7cfbc8e) into master (fbc9576) will increase coverage by 0.01%.
The diff coverage is 88.59%.

❗ Current head 7cfbc8e differs from pull request most recent head f4f151a. Consider uploading reports for the commit f4f151a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   96.65%   96.67%   +0.01%     
==========================================
  Files          35       36       +1     
  Lines        4340     4365      +25     
==========================================
+ Hits         4195     4220      +25     
  Misses        145      145              
Impacted Files Coverage Δ
lib/Request.js 87.27% <87.27%> (ø)
lib/User.js 96.66% <90.58%> (-3.34%) ⬇️
core/loadModules.js 100.00% <100.00%> (ø)
hooks/sapling/user/recover.js 100.00% <100.00%> (ø)
hooks/sapling/user/register.js 98.11% <100.00%> (ø)
hooks/sapling/user/update.js 100.00% <100.00%> (ø)
lib/Storage.js 83.57% <100.00%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbc9576...f4f151a. Read the comment docs.

@groenroos groenroos merged commit 6349d09 into master Aug 4, 2021
@groenroos groenroos deleted the maintenance/split-storage branch August 4, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Drastic code quality improvements
Development

Successfully merging this pull request may close these issues.

Split out Storage
1 participant