Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert recent portal/tooltip changes #1372

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Jul 11, 2024

The changes introduced in v2.3.4, v2.3.5 and v2.3.6 caused issues for the studio, where tooltips inside of modals would not appear anymore. To unblock users, I'd rather revert these changes now and investigate how we can reduce layout thrashing in a more structured manner once released.

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sanity-ui-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 8:53pm
sanity-ui-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 8:53pm

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@storybook/[email protected] None 0 67.2 kB yannbf
npm/@types/[email protected] None 0 35.4 kB types

View full report↗︎

@rexxars rexxars enabled auto-merge (squash) July 11, 2024 21:00
Copy link
Contributor

@ricokahler ricokahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this is a simple revert, let's merge!

@rexxars rexxars merged commit 627003e into main Jul 11, 2024
11 checks passed
@rexxars rexxars deleted the revert/portal-tooltip-changes branch July 11, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants