-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce layout trashing #1369
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@storybook/[email protected], npm/@types/[email protected] |
stipsan
force-pushed
the
reduce-layout-trashing
branch
from
July 10, 2024 18:57
03d4f76
to
fe59145
Compare
This was referenced Jul 10, 2024
rdunk
approved these changes
Jul 11, 2024
This was referenced Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a complete fix, but it reduces layout trashing by no longer reading
document.body.offsetWidth
during a snapshot handler ofuseSyncExternalStore
.The "React way" of measuring layout is to use
useLayoutEffect
: https://react.dev/reference/react/useLayoutEffect#measuring-layout-before-the-browser-repaints-the-screenA follow up PR (based on #1368) will move tooltip layout measuring to use the
size
middleware, which is equivalent to usinguseLayoutEffect
and completely solves layout trashing during render.However, refactoring to that middleware requires more testing to ensure it doesn't cause regression bugs. That's the main justification for this PR.
While at it this PR:
@sanity/prettier-config
.storybook
that happens duringpnpm install
: