-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: standardize on workspace protocol for all workspace dependencies #6088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
requested review from
skogsmaskin and
jtpetty
and removed request for
a team
March 20, 2024 14:44
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
jtpetty
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No changes to documentation |
Component Testing Report Updated Mar 20, 2024 2:54 PM (UTC)
|
hermanwikner
pushed a commit
that referenced
this pull request
Mar 21, 2024
hermanwikner
pushed a commit
that referenced
this pull request
Mar 21, 2024
hermanwikner
pushed a commit
that referenced
this pull request
Mar 21, 2024
hermanwikner
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had a mix of using
workspace:*
and version numbers for workspace dependencies. This standardizes on usingworkspace:*
for all (this should help in reducing the potential for merge conflicts as well)Note: pnpm/lerna will rewrite these to actual version numbers during publish
What to review
Did I miss any? 😅
Testing
n/a
Notes for release
N/A - not user facing