Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: use workspace protocol for all workspace dependencies (#… #6092

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Revert "fix: use workspace protocol for all workspace dependencies (#… #6092

merged 1 commit into from
Mar 20, 2024

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Mar 20, 2024

…6088)"

This reverts commit 0653134.

Description

Reverts the above mentioned commits till we can fix CLI tests to work with workspace identifier

What to review

Testing

Notes for release

N/A

@binoy14 binoy14 requested a review from a team March 20, 2024 16:03
@binoy14 binoy14 requested a review from a team as a code owner March 20, 2024 16:03
@binoy14 binoy14 requested review from pedrobonamin, juice49 and bjoerge and removed request for a team March 20, 2024 16:03
@vercel Vercel
Copy link

vercel bot commented Mar 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 20, 2024 4:06pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 4:06pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 20, 2024 4:06pm

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Mar 20, 2024 4:12 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 0s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@binoy14 binoy14 added this pull request to the merge queue Mar 20, 2024
Merged via the queue into next with commit abfc5d2 Mar 20, 2024
36 checks passed
@binoy14 binoy14 deleted the chore/revert-workspace-package branch March 20, 2024 16:28
hermanwikner pushed a commit that referenced this pull request Mar 21, 2024
@binoy14 @hermanwikner
Revert "fix: use workspace protocol for all workspace dependencies (#…
798c58e 
…6088)" (#6092)

This reverts commit 0653134.
hermanwikner pushed a commit that referenced this pull request Mar 21, 2024
@binoy14 @hermanwikner
Revert "fix: use workspace protocol for all workspace dependencies (#…
d180666 
…6088)" (#6092)

This reverts commit 0653134.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

@pedrobonamin pedrobonamin Awaiting requested review from pedrobonamin

@juice49 juice49 Awaiting requested review from juice49 juice49 was automatically assigned from sanity-io/sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binoy14 @bjoerge