Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): increase default width of PT inline popovers #5878

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix(core): increase default width of PT inline popovers #5878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
339f412
fix(core): increase default width of annotation popover
ninaandal Feb 29, 2024
f224a52
fix(core): increase default width of all inline object popovers
ninaandal Mar 1, 2024
bf4e215
fix(core): remove width prop from annotation popover
ninaandal Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sanity/src/core/form/inputs/PortableText/object/modals/ObjectEditModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export function ObjectEditModal(props: {
onClose()
}, [onClose])

const modalWidth = schemaModalOption?.width || 1
const modalWidth = schemaModalOption?.width

if (modalType === 'popover') {
return (
Expand Down
2 changes: 1 addition & 1 deletion packages/sanity/src/core/form/inputs/PortableText/object/modals/PopoverModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ interface PopoverEditDialogProps {
const POPOVER_FALLBACK_PLACEMENTS: PopoverProps['fallbackPlacements'] = ['top', 'bottom']

export function PopoverEditDialog(props: PopoverEditDialogProps) {
const {floatingBoundary, referenceBoundary, referenceElement, width = 0} = props
const {floatingBoundary, referenceBoundary, referenceElement, width = 1} = props
const [open, setOpen] = useState(false)

// This hook is here to set open after the initial render.
Expand Down
Loading