fix(core): increase default width of PT inline popovers #5878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninaandal
requested review from
a team and
pedrobonamin
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Mar 20, 2024 6:38 AM (UTC)
|
ninaandal
changed the title
ninaandal
force-pushed
the
fix/annotation-popover-width
branch
from
9909dd3
to
bf4e215
Compare
pedrobonamin
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was decided that the width of the reference selectors in the PT should be increased - this has already been merged.
For consistency, the default width of the all inline popovers in PT is increased to match the other inline popovers in portable text. I've therefore now set the default width in the
RootPopoverinstead and removed it from theInlineObjectspopover.This default width can be overwritten in the schema.
What to review
That the width of all inline objects in the PT has a default width that is wider.
Testing
Notes for release
Increased width of all inline PT popovers.