fix(core): add missing aria-labels to navbar icons

packages/sanity/src/core/components/StatusButton.tsx

@@ -1,5 +1,6 @@
 import {useTheme} from '@sanity/ui'
 import {type ForwardedRef, forwardRef, type HTMLProps, type ReactNode, useMemo} from 'react'
+import {useTranslation} from 'react-i18next'
 import styled from 'styled-components'
 
 import {Button, type ButtonProps} from '../../ui-components'
@@ -38,6 +39,7 @@ export const StatusButton = forwardRef(function StatusButton(
 ) {
   const {disabled: disabledProp, icon, label, mode = 'bleed', text, tone, ...restProps} = props
   const theme = useTheme()
+  const {t} = useTranslation()
   const toneColor = tone && theme.sanity.color.solid[tone]
   const dotStyle = useMemo(() => ({backgroundColor: toneColor?.enabled.bg}), [toneColor])
   const disabled = Boolean(disabledProp)
@@ -46,7 +48,7 @@ export const StatusButton = forwardRef(function StatusButton(
     <StyledButton
       data-ui="StatusButton"
       {...restProps}
-      aria-label={label}
+      aria-label={label || t('status-button.aria-label')}
       disabled={disabled}
       mode={mode}
       ref={ref}

packages/sanity/src/core/i18n/bundles/studio.ts

@@ -1055,14 +1055,16 @@ export const studioLocaleStrings = defineLocalesResources('studio', {
 
   /** Label for action to manage members of the current studio project */
   'presence.action.manage-members': 'Manage members',
-  /** Accessibility label for Avatar Stack */
-  'presence.aria-label': 'Who is here',
+  /** Accessibility label for presence menu button */
+  'presence.aria-label': 'Global presence',
   /** Message description for when no one else is currently present */
   'presence.no-one-else-description': 'Invite people to the project to see their online status.',
   /** Message title for when no one else is currently present */
   'presence.no-one-else-title': 'No one else is here',
   /** Message for when a user is not in a document (displayed in the global presence menu) */
   'presence.not-in-a-document': 'Not in a document',
+  /** Tooltip content text for presence menu button */
+  'presence.tooltip-content': 'Who is here',
 
   /** Fallback title shown when a preview does not provide a title */
   'preview.default.title-fallback': 'Untitled',
@@ -1524,6 +1526,8 @@ export const studioLocaleStrings = defineLocalesResources('studio', {
   'search.recent-searches-label': 'Recent searches',
   /** Accessibility label for the search results section, shown when the user has typed valid terms */
   'search.search-results-aria-label': 'Search results',
+  /** Accessibility label for the navbar status button */
+  'status-button.aria-label': 'Configuration status',
 
   /** Description for error when the timeline for the given document can't be loaded */
   'timeline.error.load-document-changes-description':

packages/sanity/src/core/studio/components/navbar/presence/PresenceMenu.tsx

@@ -53,8 +53,7 @@ export function PresenceMenu() {
         mode="bleed"
         tone={hasPresence ? 'positive' : undefined}
         tooltipProps={{
-          // @todo: rename, as its no longer an aria-label
-          content: t('presence.aria-label'),
+          content: t('presence.tooltip-content'),
         }}
       />
     )
@@ -74,6 +73,7 @@ export function PresenceMenu() {
   return (
     <MenuButton
       button={button}
+      aria-label={t('presence.aria-label')}
       id="global-presence-menu"
       menu={
         <StyledMenu>