Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add missing aria-labels to navbar icons #5810

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix(core): add missing aria-labels to navbar icons #5810

merged 1 commit into from
Feb 21, 2024

Conversation

ninaandal
Copy link
Contributor

Description

Adding some missing aria-labels to navbar buttons that are icons without labels

What to review

Testing

Notes for release

@ninaandal ninaandal requested a review from a team February 21, 2024 11:22
@ninaandal ninaandal requested a review from a team as a code owner February 21, 2024 11:22
@ninaandal ninaandal requested review from jtpetty and removed request for a team February 21, 2024 11:22
Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 21, 2024 11:27am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 11:27am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2024 11:27am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Feb 21, 2024 11:30 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 59s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@ninaandal ninaandal added this pull request to the merge queue Feb 21, 2024
Merged via the queue into next with commit ea8f97a Feb 21, 2024
40 checks passed
@ninaandal ninaandal deleted the edx-97 branch February 21, 2024 14:09
bjoerge added a commit that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants