fix(core/inputs): fix issues with calling onPathFocus for PT-input #5794
Conversation
…spans We forgot to call this normally for anything else than spans. Also added some code comments.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Component Testing Report Updated Feb 19, 2024 7:32 PM (UTC)
|
|
No changes to documentation |
Test that spans are reported with .text and everything else not.
skogsmaskin
force-pushed
the
fix/add-missing-invocation
branch
from
675fd22
to
291d6bb
Compare
| const pushPath = (path: Path) => paths.push(path) | ||
| await mount(<FocusTrackingStory document={document} onPathFocus={pushPath} />) | ||
| const {getFocusedPortableTextEditor} = testHelpers({page}) | ||
| const $pte = await getFocusedPortableTextEditor('field-body') |
There was a problem hiding this comment.
Not a huge deal, but is there any particular meaning behind the $-prefix here? I guess it's because these refer to DOM elements, but my impression is that it's not a commonly used convention these days, since you can easily tell from the type anyway(?)
There was a problem hiding this comment.
It's to signal that it's a (synchronous) Locator instance.
The test suite started with this convention, and I think the Playwright documentation used to have this convention in their examples, but I can't find them anymore. I'm all in for not using them, but then we should follow the same convention everywhere within our test suite.
Description
I discovered some issues in #5786.
onPathFocuson anything else than spans.I have added some Playwright-CT tests for this functionality now that test the values emitted by
onPathFocusfor focus on spans, inline blocks, and block objects.What to review
The bi-directionality and production of paths for various types of content should now be fully covered by the tests.
Testing
Notes for release
N/A - should use notes from #5786