refactor(core/inputs): report focusPath on text spans ending with .text #5786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skogsmaskin
requested review from
a team and
jtpetty
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
| // It's a bit ugly right here, but it's a rather simple way to support the Presentation tool without | ||
| // having to change the PTE's internals. | ||
| if ( | ||
| focusPath.length === 3 && |
There was a problem hiding this comment.
Paraphrasing tommy, why is the length === 3 here? What does it means when it's 3?
There was a problem hiding this comment.
It means that the path is pointing directly to a block child, i.e:
[{_key: 'xxx'}, 'children', {_key: 'yyy'}] - where xxx is the block and yyy is the child.
|
Component Testing Report Updated Feb 19, 2024 11:19 AM (UTC)
|
…paths ending with .text
…Path on same length This will ensure that any external focusPath is compared with the relevant length of something visible in the editor. If there is something pointing further into an object, we don't care, because it's only relevant so far regarding setting focus in the editor.
skogsmaskin
force-pushed
the
edx-1075
branch
from
f440bad
to
f784609
Compare
stipsan
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will make the PT-input report the
focusPathwhen the focus is on text spans ending withtextso that the Presentation Tool can work out of the box without making any exceptions for the PT-input.With this change, we have a bi-directional mapping of focus with the forms and the presentation tool.
Note that this will not change the PTE
EditorSelectionwhich will continue reporting as before, it's only the studio-specificfocusPathreporting that will be affected by this change.What to review
Testing
Notes for release