-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comments): introduce inline commenting #5606
Merged
Merged
+3,988
−598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanwikner
requested review from
skogsmaskin and
rexxars
and removed request for
a team
January 30, 2024 14:32
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Report@sanity/portable-text-editor
@sanity/migrate
sanity
@sanity/diff
@sanity/block-tools
@sanity/types
sanity/desk
@sanity/mutator
@sanity/cli
sanity/structure
@sanity/util/concurrency-limiter
@sanity/util/legacyDateFormat
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/client
@sanity/util/createSafeJsonParser
sanity/_internalBrowser
@sanity/util/content
|
Component Testing Report Updated Mar 1, 2024 4:04 PM (UTC)
|
hermanwikner
force-pushed
the
edx-838-inline-comments
branch
from
January 30, 2024 14:43
c01a705
to
091a27c
Compare
hermanwikner
force-pushed
the
edx-838-inline-comments
branch
from
January 31, 2024 09:42
864353e
to
f82d50e
Compare
* Fixes an issue where adding text inside single word ranges didn't expand correctly * Fixes an issue where bolding partially inside a range expanded the range incorrectly * Replaces child and comment range start/end indicators with unused utf-8 chars to avoid conflicts with user content
Have each test in it's own file to make them easier to write and read. Ditch snapshot testing and test against hard coded values that makes it easier to undstand what is going on.
Improve invalidation of range decorations when text is edited
Improve how we move and update range decorations when content is edited
skogsmaskin
force-pushed
the
edx-838-inline-comments
branch
from
March 1, 2024 15:53
e1f9e76
to
1fd98c6
Compare
skogsmaskin
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the capability for inline text commenting within block content. Users can now highlight a specific segment of text and attach a comment to it.
What to Review
Gotchas
Testing
Notes for Release
Users can now make comments on specific text selections within block content