Skip to content

Commit

Permalink
chore(comments): temporarily disable inline comments
Browse files Browse the repository at this point in the history
  • Loading branch information
hermanwikner authored and skogsmaskin committed Mar 1, 2024
1 parent 1cc4611 commit 1fd98c6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions packages/sanity/src/structure/comments/plugin/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {definePlugin} from 'sanity'
import {commentsUsEnglishLocaleBundle} from '../i18n'
import {CommentsDocumentLayout} from './document-layout'
import {CommentsField} from './field'
import {CommentsInput} from './input'
// import {CommentsInput} from './input'
import {commentsInspector} from './inspector'
import {CommentsStudioLayout} from './studio-layout'

Expand All @@ -20,7 +20,8 @@ export const comments = definePlugin({
form: {
components: {
field: CommentsField,
input: CommentsInput,
// The `CommentsInput` will be enabled when it is ready to be used.
// input: CommentsInput,
},
},

Expand Down
5 changes: 3 additions & 2 deletions test/e2e/tests/comments/inline.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,16 @@ async function inlineCommentCreationTest(props: InlineCommentCreationTestProps)
await expect(commentsListItemReferencedValue).toHaveText(PTE_CONTENT_TEXT)
}

// The tests will be enabled when the inline comments feature is ready to be used.
test.describe('Inline comments:', () => {
test('should create inline comment', async ({page, createDraftDocument, browserName}) => {
test.skip('should create inline comment', async ({page, createDraftDocument, browserName}) => {
// For now, only test in Chromium due to flakiness in Firefox and WebKit
test.skip(browserName !== 'chromium')

await inlineCommentCreationTest({page, createDraftDocument})
})

test('should resolve inline comment', async ({page, createDraftDocument, browserName}) => {
test.skip('should resolve inline comment', async ({page, createDraftDocument, browserName}) => {
// For now, only test in Chromium due to flakiness in Firefox and WebKit
test.skip(browserName !== 'chromium')

Expand Down

0 comments on commit 1fd98c6

Please sign in to comment.