Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Y24-190-2: Support Limber labware metadata in API v2 #4268

Merged
merged 12 commits into from
Aug 14, 2024
Merged

Y24-190-2: Support Limber labware metadata in API v2 #4268

merged 12 commits into from
Aug 14, 2024

Commits on Jul 24, 2024

  1. Clean up implementation of CustomMetadatumCollection

    @sdjmchattie
    sdjmchattie committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a39e2a3 View commit details
    Browse the repository at this point in the history

  2. Separate expectations into different test cases

    @sdjmchattie
    sdjmchattie committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    8c7d622 View commit details
    Browse the repository at this point in the history

  3. Capture the expectation before applying the failing method

    @sdjmchattie
    sdjmchattie committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4f653cd View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Fix the devour tasks 

    They were failing when they found Concerns and SharedBehaviour sub modules which did not contain JSONAPI::Resource implementations.
    @sdjmchattie
    sdjmchattie committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    6466af5 View commit details
    Browse the repository at this point in the history

  2. Extract immutable array from loop 

    Presumably for efficiency, which we shouldn't be concerned about here, but Rubocop insists!
    @sdjmchattie
    sdjmchattie committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    aa42dc7 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Fix YARD documentation of attributes on CustomMetadatumCollection

    @sdjmchattie
    sdjmchattie committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    16aa1b1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop-Y24-190' into Y24-190-2-support-limber-labware-… 

    …metadata-in-api-v2

# Conflicts:
#	spec/requests/api/v2/custom_metadatum_collections_spec.rb
    @sdjmchattie
    sdjmchattie committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d429893 View commit details
    Browse the repository at this point in the history

  3. Fix unintended over indentation of spec

    @sdjmchattie
    sdjmchattie committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    b2377e0 View commit details
    Browse the repository at this point in the history

  4. Add documentation to the UserResource plus a new uuid filter

    @sdjmchattie
    sdjmchattie committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    4422d5f View commit details
    Browse the repository at this point in the history

  5. Update tests for the User V2 API endpoint

    @sdjmchattie
    sdjmchattie committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    0781b22 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Add tests for filtering Users by UUID

    @sdjmchattie
    sdjmchattie committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    528c937 View commit details
    Browse the repository at this point in the history

  2. Don't repeat check for changed resource data

    @sdjmchattie
    sdjmchattie committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    dd64950 View commit details
    Browse the repository at this point in the history