Y24-190-2: Support Limber labware metadata in API v2 #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were failing when they found Concerns and SharedBehaviour sub modules which did not contain JSONAPI::Resource implementations.
Presumably for efficiency, which we shouldn't be concerned about here, but Rubocop insists!
…metadata-in-api-v2 # Conflicts: # spec/requests/api/v2/custom_metadatum_collections_spec.rb
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-Y24-190 #4268 +/- ##
===================================================
+ Coverage 86.79% 86.82% +0.02%
===================================================
Files 1371 1371
Lines 29761 29766 +5
===================================================
+ Hits 25831 25843 +12
+ Misses 3930 3923 -7 ☔ View full report in Codecov by Sentry. |
BenTopping
requested changes
Aug 13, 2024
BenTopping
approved these changes
Aug 14, 2024
sdjmchattie
deleted the
Y24-190-2-support-limber-labware-metadata-in-api-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4223
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code