Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stock plate as limber plate #1907

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

add stock plate as limber plate #1907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7946080
add stock plate as limber plate
wendyyang Sep 9, 2024
dd2bd0d
separate stock plate just for 10x - CITEseq and Emseq pipelines
wendyyang Sep 11, 2024
56c7ee1
extend stock plate as input plate to other pipelines
wendyyang Sep 11, 2024
e31e4ad
fix formating
wendyyang Sep 11, 2024
763d303
Merge branch 'develop' into allow_submission_from_stock_plate
yoldas Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions config/pipelines/bespoke_pcr.yml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke to Liz C and Siobhan in a meeting with Steve about the wider 'fake cherrypicking' story. They said that they would like the Stock Plate entry point to be enabled for everything in this file please. i.e. All of the library types, and the other pipelines in the file (BCR, TCR etc.).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the changes as request. But for the last pipeline:
Bespoke PCR MX:
pipeline_group: Bespoke PCR
filters:
request_type_key:
- limber_multiplexing
relationships:
LBB Lib PCR-XP: LBB Lib Pool Stock
LBB Lib Pool Stock: LB Lib Pool Norm

There is no cherrypick plate, hence didn't add 'stock plate' to the pipeline and leave as it is, please confirm if it is correct.

Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,19 @@ Bespoke PCR:
- SGE Library v0.2
library_pass: LBB Lib PCR-XP
relationships:
Stock Plate: LBB Ligation
LBB Cherrypick: LBB Ligation
LBC Cherrypick: LBB Ligation
LBB Ligation: LBB Lib PCR-XP

Bespoke PCR BCR:
filters:
request_type_key: limber_pcr_bespoke
library_type:
- Manual Chromium single cell BCR
library_pass: LBB Lib PCR-XP
relationships:
Stock Plate: LBB Enriched BCR
LBB Cherrypick: LBB Enriched BCR
LBC Cherrypick: LBB Enriched BCR
LBB Enriched BCR: LBB Ligation
Expand All @@ -56,6 +59,7 @@ Bespoke PCR BCR HT:
- Manual Chromium single cell BCR HT
library_pass: LBB Lib PCR-XP
relationships:
Stock Plate: LBB Enriched BCR HT
LBB Cherrypick: LBB Enriched BCR HT
LBC Cherrypick: LBB Enriched BCR HT
LBB Enriched BCR HT: LBB Ligation
Expand All @@ -67,6 +71,7 @@ Bespoke PCR TCR:
- Manual Chromium single cell TCR
library_pass: LBB Lib PCR-XP
relationships:
Stock Plate: LBB Enriched TCR
LBB Cherrypick: LBB Enriched TCR
LBC Cherrypick: LBB Enriched TCR
LBB Enriched TCR: LBB Ligation
Expand All @@ -78,6 +83,7 @@ Bespoke PCR TCR HT:
- Manual Chromium single cell TCR HT
library_pass: LBB Lib PCR-XP
relationships:
Stock Plate: LBB Enriched TCR HT
LBB Cherrypick: LBB Enriched TCR HT
LBC Cherrypick: LBB Enriched TCR HT
LBB Enriched TCR HT: LBB Ligation
Expand Down
5 changes: 5 additions & 0 deletions config/purposes/bespoke.yml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document somewhere (e.g. comment on the story) that you'll have to do a manual update to change the Stock Plate purpose to be an 'input' plate, and how you plan to do it? Thanks.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote the manual update plan in SS pull request proposed changes. please review again for the SS PR. Thank you!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also added to the story comment too.

Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,8 @@ LBB Enriched TCR:
LBB Enriched TCR HT:
:asset_type: plate
:creator_class: LabwareCreators::PartialStampedPlateWithoutDilution
Stock Plate:
:asset_type: plate
:stock_plate: true
:input_plate: true
:presenter_class: Presenters::StockPlatePresenter
Loading