-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stock plate as limber plate #1907
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1907 +/- ##
========================================
Coverage 77.95% 77.95%
========================================
Files 459 459
Lines 17694 17694
Branches 225 225
========================================
Hits 13794 13794
Misses 3898 3898
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spoke to Liz C and Siobhan in a meeting with Steve about the wider 'fake cherrypicking' story. They said that they would like the Stock Plate entry point to be enabled for everything in this file please. i.e. All of the library types, and the other pipelines in the file (BCR, TCR etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the changes as request. But for the last pipeline:
Bespoke PCR MX:
pipeline_group: Bespoke PCR
filters:
request_type_key:
- limber_multiplexing
relationships:
LBB Lib PCR-XP: LBB Lib Pool Stock
LBB Lib Pool Stock: LB Lib Pool Norm
There is no cherrypick plate, hence didn't add 'stock plate' to the pipeline and leave as it is, please confirm if it is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document somewhere (e.g. comment on the story) that you'll have to do a manual update to change the Stock Plate purpose to be an 'input' plate, and how you plan to do it? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote the manual update plan in SS pull request proposed changes. please review again for the SS PR. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also added to the story comment too.
Code Climate has analyzed commit 763d303 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.1% (0.0% change). View more on Code Climate. |
Closes #
Changes proposed in this pull request
add Stock plate to the pipelines
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version