parse: document inconsistencies of S.parseDate #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bradcomp
reviewed
Feb 22, 2019
|
|
|
I'll update this pull request once davidchambers/doctest#110 has been merged and released. :) |
davidchambers
commented
Mar 9, 2019
| //. > strongly discouraged due to browser differences and inconsistencies. | ||
| //. > Support for RFC 2822 format strings is by convention only. Support for | ||
| //. > ISO 8601 formats differs in that date-only strings (e.g. "1970-01-01") | ||
| //. > are treated as UTC, not local. |
There was a problem hiding this comment.
Thanks to davidchambers/doctest#110, sanctuary-js/sanctuary-scripts#20, and #607 we are now able to use Markdown syntax for this block quotation. Quite the diversion!
As explained in remarkjs/remark-lint#207, it is necessary to use \[…] rather than simply […] to avoid triggering a no-undefined-references error.
davidchambers
force-pushed
the
davidchambers/parse-date
branch
from
c0d68f1 to
cd27813
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #488
I used
<blockquote>rather than the equivalent Markdown syntax, because lines beginning with>are treated as doctest input. Ideally, only lines beginning with>within```javascriptcode blocks would be evaluated, but doctest doesn't support this use case.