Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctest: specify ‘opening-delimiter’ so doctests are detected and run #10

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

davidchambers
Copy link
Contributor

Merging #9 inadvertently disabled the doctests.

This pull request is one of two possible fixes. The other option is to replace occurrences of ```js in index.js with ```javascript, allowing us to use the default opening-delimiter value.

If you would prefer to stick with ```js, Aldwin, you're welcome to merge this pull request. If you would prefer to avoid another .config entry, close this pull request and I will open a new one.

@Avaq
Copy link
Owner

Avaq commented Mar 19, 2019

Merging #9 inadvertently disabled the doctests.

Did the introduction of the opening-delimiter option change the "default" opening delimiter? That was not immediately obvious from reading the sanctuary-scripts release notes.

@Avaq
Copy link
Owner

Avaq commented Mar 19, 2019

Thank you! :)

@Avaq Avaq merged commit 82bda6e into Avaq:master Mar 19, 2019
@davidchambers davidchambers deleted the doctest branch March 19, 2019 13:52
@davidchambers
Copy link
Contributor Author

Did the introduction of the opening-delimiter option change the "default" opening delimiter?

Prior to [email protected], doctest attempted to process every prefixed comment line. This proved problematic in sanctuary-js/sanctuary#600, because the Markdown syntax for block quotations is the same as the doctest syntax for input lines. To resolve this conflict we made it possible to specify, via delimiters, the regions in which doctest should attempt to process prefixed comment lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants